chore: honor restic retention settings #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit I added is fixing your merge conflicts with the version bump. I fixed the issue by just not caring about the version number in git. |
|
Thanks for noticing the discrepancy in the variable names. I appreciate the approach you took by not breaking it for either naming scheme. |
|
Thanks for the contribution @igolman! Nice work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋 ,
I hope this finds you well.
There is a discrepancy between the documentation/examples for backup snapshots retention and the actual code.
According to README and
stack-back.env.templateone should useRESTIC_prefix with theKEEP_*env variables for the retentions settings.However in
config.pyit will fetch just theKEEP_*env variables, i.e. without the prefix. If one defines the backup retention using theRESTIC_prefix, the retention will fall back to default values.This PR takes both approaches into account, since someone may be already using the
KEEP_*variant. Hence it is not introducing any break changes.